Documentation
¶
Index ¶
- Constants
- func IsFullKeyRange(kr string) bool
- func StatusRow(a Applier) string
- func ValidateKeyRanges(ranges []string) error
- type Applier
- type ApplierConfig
- type ApplyCallback
- type LogicalRow
- type MockApplier
- func (m *MockApplier) Apply(ctx context.Context, chunk *table.Chunk, rows [][]any, callback ApplyCallback) error
- func (m *MockApplier) ApplyCalls() [][][]any
- func (m *MockApplier) DeleteCalls() [][][]any
- func (m *MockApplier) DeleteKeys(ctx context.Context, sourceTable, targetTable *table.TableInfo, keys [][]any, ...) (int64, error)
- func (m *MockApplier) GetTargets() []Target
- func (m *MockApplier) Reset()
- func (m *MockApplier) Start(ctx context.Context) error
- func (m *MockApplier) Starts() int
- func (m *MockApplier) Stats() Stats
- func (m *MockApplier) Stop() error
- func (m *MockApplier) Stops() int
- func (m *MockApplier) UpsertCalls() [][]LogicalRow
- func (m *MockApplier) UpsertRows(ctx context.Context, mapping *table.ColumnMapping, rows []LogicalRow, ...) (int64, error)
- func (m *MockApplier) Wait(ctx context.Context) error
- func (m *MockApplier) Waits() int
- type MySQLApplier
- func (a *MySQLApplier) ActiveWriteWorkers() int
- func (a *MySQLApplier) Apply(ctx context.Context, chunk *table.Chunk, rows [][]any, callback ApplyCallback) error
- func (a *MySQLApplier) DeleteKeys(ctx context.Context, sourceTable, targetTable *table.TableInfo, keys [][]any, ...) (int64, error)
- func (a *MySQLApplier) GetTargets() []Target
- func (a *MySQLApplier) SetInitialWriteWorkers(n int)
- func (a *MySQLApplier) SetWriteWorkers(n int)
- func (a *MySQLApplier) Start(ctx context.Context) error
- func (a *MySQLApplier) Stats() Stats
- func (a *MySQLApplier) Stop() error
- func (a *MySQLApplier) UpsertRows(ctx context.Context, mapping *table.ColumnMapping, rows []LogicalRow, ...) (int64, error)
- func (a *MySQLApplier) Wait(ctx context.Context) error
- type Stats
- type Target
Constants ¶
const ( // MaxStatementSizeBytes is the byte budget for the estimated rendered // size of a single multi-row DML statement (1 MiB). Both write paths // batch against it: the copy path splits chunks into chunklets // (splitRowsIntoChunklets) and the binlog-apply path cuts flush // batches (pkg/change) so a REPLACE/DELETE can't grow unbounded with // wide rows. Still far below the typical 64 MiB max_allowed_packet // because the size estimates are rough — utils.EstimateRenderedRowSize is // deliberately biased low (hex encoding, string escaping and wide // integers all under-measure; see its doc) and leans on that ~64x // headroom — and a single row larger than the budget still goes in // its own statement. // // One bound to respect when changing this: chunklets must keep the write // pool fed, so chunks-in-flight x chunklets-per-chunk has to stay above the // write worker count. At a 16 MiB target chunk, ~22 chunks in flight and a // write ceiling of 188 that means >= ~8.5 chunklets per chunk, i.e. the // budget can only roughly double before the largest pools start starving. // (When chunkletMaxRows binds instead, chunklets-per-chunk is set by the // row count and this bound is much looser.) MaxStatementSizeBytes = 1024 * 1024 )
Variables ¶
This section is empty.
Functions ¶
func IsFullKeyRange ¶ added in v0.18.0
IsFullKeyRange reports whether kr is a valid Vitess-style key range that covers the whole key space ("", "0", "-", "0-"). A one-target applier with such a range writes every row without routing; any other range routes, so rows outside it are refused. Callers that write one logical target use this to reject a partial range before setup.
func StatusRow ¶ added in v0.17.0
StatusRow renders a's Stats() as the applier row of a runner status block. Runner Status() can be called before the applier is constructed, so this must be nil-safe; the empty string it returns then makes the block drop the row.
func ValidateKeyRanges ¶ added in v0.16.0
ValidateKeyRanges parses each Vitess-style key range and checks that no two overlap — the same rules New enforces at construction. It exists so callers can fail fast on a bad shard layout before doing any work (e.g. move validates reverse-window source key ranges before the copy, since the sharded reverse applier is only constructed after the forward cutover).
Types ¶
type Applier ¶
type Applier interface {
// Start initializes the applier and starts its workers
Start(ctx context.Context) error
// Apply sends rows to be written to the target(s).
// The chunk parameter provides metadata about the source table and target table.
// The rows parameter contains the actual row data to be written.
// The callback is invoked when all rows are safely flushed.
//
// For the copier: callback will call chunker.Feedback()
// For the subscription: callback will update binlog coordinates
Apply(ctx context.Context, chunk *table.Chunk, rows [][]any, callback ApplyCallback) error
// Stats returns a point-in-time snapshot of the write pipeline: queue
// occupancy, pending work, live workers, mean rows per chunklet, and
// rolling percentiles of the four per-chunklet phases (queue-wait, build,
// write, handoff). Safe to call concurrently with Apply; values are
// approximate. See the Stats type for field semantics.
Stats() Stats
// DeleteKeys deletes rows by their key values synchronously. Each entry
// in keys is one key tuple of the original (typed) column values, in
// sourceTable.KeyColumns order.
// An empty locks slice means no under-lock flush: the delete runs on the
// regular write connection(s). When locks is non-empty, the delete is
// executed under the supplied table lock(s): one lock per target, each
// acquired on that target's own connection (the same *sql.DB as
// Target.DB). Each target's statements run under that target's lock,
// matched by connection identity. A missing lock for any target, or a lock
// that matches no target, is an error.
// Returns the number of rows affected and any error.
DeleteKeys(ctx context.Context, sourceTable, targetTable *table.TableInfo, keys [][]any, locks []*dbconn.TableLock) (int64, error)
// UpsertRows performs an upsert (REPLACE INTO ... VALUES) synchronously.
// The rows are LogicalRow structs containing the row images.
// An empty locks slice means no under-lock flush; when locks is non-empty
// the upsert is executed under the supplied table lock(s). See DeleteKeys
// for the lock contract (one lock per target).
// Returns the number of rows affected and any error.
UpsertRows(ctx context.Context, mapping *table.ColumnMapping, rows []LogicalRow, locks []*dbconn.TableLock) (int64, error)
// Wait blocks until all pending work is complete and all callbacks have been invoked
Wait(ctx context.Context) error
// Stops the applier workers
Stop() error
// GetTargets returns target information for direct database access.
// This is used by operations like checksum that need to query targets directly.
GetTargets() []Target
}
Applier is an interface for applying rows to one or more target databases. MySQLApplier is the implementation: it writes to a single target, or fans out to multiple targets based on a hash function.
The Applier is responsible for: - Batching/splitting rows into optimal write sizes - Tracking pending writes - Invoking callbacks when writes are complete
func NewSingleTargetForTest ¶ added in v0.13.0
NewSingleTargetForTest builds a single-target MySQLApplier suitable for use as the repl client's applier. The repl client requires a non-nil applier — every memory-comparable PK routes through bufferedMap, which calls Applier.UpsertRows / DeleteKeys. See issue #746.
type ApplierConfig ¶
type ApplierConfig struct {
Threads int // number of write threads
Logger *slog.Logger
DBConfig *dbconn.DBConfig
// MetricsSink, when non-nil, makes the applier periodically report its
// Stats() snapshot as gauges (see pkg/metrics applier_* names). Nil
// disables emission entirely — no goroutine is started.
MetricsSink metrics.Sink
}
ApplierConfig configures the write workers and their connections. Chunklet limits are fixed at chunkletMaxRows and MaxStatementSizeBytes.
func NewApplierDefaultConfig ¶
func NewApplierDefaultConfig() *ApplierConfig
NewApplierDefaultConfig returns a default config for the applier.
func (*ApplierConfig) Validate ¶
func (cfg *ApplierConfig) Validate() error
Validate checks the ApplierConfig for required fields.
type ApplyCallback ¶
ApplyCallback is invoked when rows have been safely flushed to the target(s). affectedRows is the total number of rows affected across all targets. err is non-nil if there was an error applying the rows.
type LogicalRow ¶
LogicalRow represents the current state of a row in the subscription buffer. This could be that it is deleted, or that it has RowImage that describes it. If there is a RowImage, then it needs to be converted into the RowImage of the newTable.
type MockApplier ¶ added in v0.18.0
type MockApplier struct {
// Inner is the applier to delegate to. Nil means this mock stands alone
// and every method succeeds without doing anything.
Inner Applier
// Targets is what GetTargets reports when Inner is nil.
Targets []Target
// FixedStats is what Stats reports when Inner is nil. The zero value is
// an idle pipeline, which is what a test that does not care about stats
// wants; set it when the code under test reads a field such as
// ActiveWorkers.
FixedStats Stats
// Error injection. Each is returned by its method instead of delegating,
// so a nil Inner is not required to make one fire.
StartErr error
ApplyErr error
WaitErr error
StopErr error
// CallbackErr is reported through Apply's callback rather than by Apply
// itself — the way a real applier surfaces a write that failed in its
// coordinator goroutine, which is a different code path in the caller
// from an Apply that returns an error.
CallbackErr error
// contains filtered or unexported fields
}
MockApplier is the shared Applier test double. It lives here rather than in each consumer's test files because every package that drives an applier — the checksum's repair path, the copier, the change feed's subscriptions, a sync runner — wants the same three things from a double, and had grown its own slightly different version of each: delegate to a real applier, or stand in for one entirely; record what was asked of it; and fail on demand.
It is a decorator, not a stub. With Inner set, every method delegates after recording, so a test can drive a real write path and still assert on the calls or inject a failure into one of them. With Inner nil, every method is a success-shaped no-op, which is what a test that only needs the interface satisfied wants. The two modes are the same type because tests routinely start as one and become the other.
It is safe to use from several goroutines. Recording is under a mutex; the error fields are not, so set them before the applier is handed to the code under test (or between synchronous calls, which is how the repair tests use them).
There is one case this is deliberately not for: a stub that exists only to satisfy a parameter the code under test must never call. Embed a nil applier.Applier there instead, so an unintended call panics and names itself rather than quietly succeeding.
func (*MockApplier) Apply ¶ added in v0.18.0
func (m *MockApplier) Apply(ctx context.Context, chunk *table.Chunk, rows [][]any, callback ApplyCallback) error
func (*MockApplier) ApplyCalls ¶ added in v0.18.0
func (m *MockApplier) ApplyCalls() [][][]any
ApplyCalls returns the row batches passed to Apply, in call order. The slices are the caller's own — do not retain them past the assertion.
func (*MockApplier) DeleteCalls ¶ added in v0.18.0
func (m *MockApplier) DeleteCalls() [][][]any
DeleteCalls returns the key batches passed to DeleteKeys, in call order.
func (*MockApplier) DeleteKeys ¶ added in v0.18.0
func (*MockApplier) GetTargets ¶ added in v0.18.0
func (m *MockApplier) GetTargets() []Target
func (*MockApplier) Reset ¶ added in v0.18.0
func (m *MockApplier) Reset()
Reset clears the recorded calls without touching Inner or the error fields, so one mock can span several phases of a test.
func (*MockApplier) Starts ¶ added in v0.18.0
func (m *MockApplier) Starts() int
Starts, Stops and Waits report the lifecycle calls made so far. Tests assert on these to pin down who owns an applier's lifecycle — whether a repair starts one per chunk or reuses the caller's, for instance.
func (*MockApplier) Stats ¶ added in v0.18.0
func (m *MockApplier) Stats() Stats
func (*MockApplier) Stop ¶ added in v0.18.0
func (m *MockApplier) Stop() error
func (*MockApplier) Stops ¶ added in v0.18.0
func (m *MockApplier) Stops() int
func (*MockApplier) UpsertCalls ¶ added in v0.18.0
func (m *MockApplier) UpsertCalls() [][]LogicalRow
UpsertCalls returns the row batches passed to UpsertRows, in call order.
func (*MockApplier) UpsertRows ¶ added in v0.18.0
func (m *MockApplier) UpsertRows(ctx context.Context, mapping *table.ColumnMapping, rows []LogicalRow, locks []*dbconn.TableLock) (int64, error)
func (*MockApplier) Waits ¶ added in v0.18.0
func (m *MockApplier) Waits() int
type MySQLApplier ¶ added in v0.18.0
MySQLApplier applies rows to one or more MySQL targets. Each target owns a key range, its own write connection and its own pool of write workers.
With one target covering the whole key space (the migration, datasync and unsharded-move case) every row goes to that target and no routing happens. With several targets (a move to a Vitess-style sharded destination) each row is routed by hashing its sharding column and picking the target whose key range contains the hash. The sharding column and hash function are configured per table in TableInfo.ShardingColumn and TableInfo.HashFunc, so different tables in one multi-table move can use different sharding keys.
func New ¶ added in v0.18.0
func New(targets []Target, cfg *ApplierConfig) (*MySQLApplier, error)
New creates a MySQLApplier that writes to targets. There must be at least one target, and no two key ranges may overlap. A single target may leave KeyRange empty (or "0"): it then covers the whole key space.
ApplierConfig.Threads is the write-worker count for EACH target, not a total divided between them (see pkg/move/move.go:WriteThreads).
func (*MySQLApplier) ActiveWriteWorkers ¶ added in v0.18.0
func (a *MySQLApplier) ActiveWriteWorkers() int
ActiveWriteWorkers returns the number of live write workers summed across all targets. SetWriteWorkers is per target, so with N targets this is N times the count SetWriteWorkers asked for.
func (*MySQLApplier) Apply ¶ added in v0.18.0
func (a *MySQLApplier) Apply(ctx context.Context, chunk *table.Chunk, rows [][]any, callback ApplyCallback) error
Apply sends rows to be written to the target(s). With several targets, rows are distributed across them based on the sharding column and hash function configured in the chunk's Table.ShardingColumn and Table.HashFunc.
func (*MySQLApplier) DeleteKeys ¶ added in v0.18.0
func (a *MySQLApplier) DeleteKeys(ctx context.Context, sourceTable, targetTable *table.TableInfo, keys [][]any, locks []*dbconn.TableLock) (int64, error)
DeleteKeys deletes rows by their key values synchronously, broadcasting to all shards. Each entry in keys is one primary-key tuple of the original (typed) column values, in sourceTable.KeyColumns order. If locks is non-empty, each shard's delete is executed under the table lock that was acquired on that shard's own connection (one lock per shard, matched via resolveShardLocks).
Note: we only track modifications by PRIMARY KEY, not by shard key (aka primary vindex). For this reason we can't extract the vindex value, and must instead broadcast the deletes to all shards. The vindex value is considered immutable, and we will error if it changes on an update.
targetTable may be nil, meaning the same name as sourceTable. A different name is used by migrations (the `_new` table) and by the reverse feed of a sharded-source move, which writes back to the source's retired `_old` tables.
func (*MySQLApplier) GetTargets ¶ added in v0.18.0
func (a *MySQLApplier) GetTargets() []Target
GetTargets returns the target database configurations for direct access. This is used by operations like checksum that need to query targets directly.
func (*MySQLApplier) SetInitialWriteWorkers ¶ added in v0.18.0
func (a *MySQLApplier) SetInitialWriteWorkers(n int)
SetInitialWriteWorkers sets the per-target worker count that subsequent starts spawn, without spawning workers. Call before Start (or after Stop has returned). A running applier is unchanged.
func (*MySQLApplier) SetWriteWorkers ¶ added in v0.18.0
func (a *MySQLApplier) SetWriteWorkers(n int)
SetWriteWorkers reconciles the live write-worker count of EACH target to n, spawning new workers or parking existing ones as needed. It is idempotent and safe to call repeatedly from an autoscaler. n is clamped to a minimum of 1 so every target always makes some progress. Calls before Start or after Stop() begins are no-ops.
Parking is cooperative: closing a worker's quit channel makes it exit the next time it returns to its select (after finishing any chunklet currently in flight), so no completion is ever lost. With several targets a controller may drive all of them from the busiest target's load, so a busy shard slows the entire move.
func (*MySQLApplier) Start ¶ added in v0.18.0
func (a *MySQLApplier) Start(ctx context.Context) error
Start initializes all shard workers and begins processing. This does not control the synchronous methods like UpsertRows/DeleteKeys. This method is idempotent and can restart the applier after Stop() is called.
Lifecycle: callers MUST call Stop() to terminate the per-shard write workers and the single feedbackCoordinator. Cancelling the ctx passed here does NOT by itself shut down the goroutine pipeline — it only aborts in-flight writes. Workers for a shard exit when its chunkletBuffer is closed (by Stop) or when their quit channel is closed (by SetWriteWorkers scaling down), and the coordinator exits when every shard's chunkletCompletions has been closed (by Stop after joining each shard's workers). Failing to call Stop() will leak goroutines.
func (*MySQLApplier) Stats ¶ added in v0.18.0
func (a *MySQLApplier) Stats() Stats
Stats returns a point-in-time snapshot of the write pipeline, aggregated across shards: queue depth/cap are summed, and active workers is the sum of each shard's pool count — goroutines currently running, which during a shrink can briefly exceed the number of quit channels the pool still tracks, since a retired worker is removed from quits before it returns. The embedded mutex is held so the buffer reads cannot race Start()'s channel reinitialization on restart; len/cap on a closed channel are safe.
func (*MySQLApplier) Stop ¶ added in v0.18.0
func (a *MySQLApplier) Stop() error
Stop signals the applier to shut down gracefully. This does not control the synchronous methods like UpsertRows/DeleteKeys, which can continue after Stop() is called. This method is idempotent - calling it multiple times is safe.
func (*MySQLApplier) UpsertRows ¶ added in v0.18.0
func (a *MySQLApplier) UpsertRows(ctx context.Context, mapping *table.ColumnMapping, rows []LogicalRow, locks []*dbconn.TableLock) (int64, error)
UpsertRows performs an upsert (REPLACE INTO ... VALUES) synchronously, distributing rows across shards. The rows are LogicalRow structs containing inline row images from the binlog. If locks is non-empty, each shard's upsert is executed under the table lock that was acquired on that shard's own connection (one lock per shard, matched via resolveShardLocks).
REPLACE semantics, and why we use them:
MySQL's `REPLACE INTO target (cols) VALUES (...)` treats each value tuple as an INSERT, except that for any row in `target` that conflicts with the new row on PRIMARY KEY *or any UNIQUE index*, the old row is deleted before the new row is inserted. Per the docs, conflicts on multiple unique indexes can lead to multiple deletions for a single new row.
Two implications matter for callers reading this code:
A single REPLACE may delete rows whose PKs are *not* in the `rows` argument. If row B's image collides on a unique key with some other row A currently in the destination (because A was the previous holder of that unique value), REPLACE deletes A while inserting B. A is then transiently missing from the destination until its own event arrives in a later flush (or a later batch in the same flush) and re-inserts it. This is what restores the order-independence the pre-#821 deltaMap had with `REPLACE INTO ... SELECT`. See block/spirit#847.
Eventual consistency. Between the moment REPLACE deletes A and the moment A's image is re-applied, the destination is not a valid snapshot of source — it has fewer rows. Spirit relies on the bufferedMap being an *up-to-date and disjoint* representation of pending changes (each PK appears at most once, holding the latest row image) so that every transiently-deleted row will be re-inserted as flushes progress. The destination converges back to source's current state once the last unflushed event for each affected PK has been applied. The post-copy checksum, which repairs, is the backstop that catches any divergence that survives.
We supply inline row images rather than `REPLACE INTO ... SELECT FROM source`, so the read-after-commit race that motivated #746 does not apply.
Sharding: we only track modifications by PRIMARY KEY, not by shard key (aka primary vindex). For this reason we could get in trouble if there was a PK update that mutated the vindex column. This is because we would only see the last operation (modification) and not know to DELETE from one of the shards.
The way we address this, is we consider the vindex column immutable. The replication client is told that it should error if there are any updates to it, and the entire operation is canceled. The enforcement lives in pkg/change: the subscription resolves the sharding column to an ordinal (Subscription.ImmutableColumnOrdinal) and feedCore.processRowsEvent fails fatally when an UPDATE's before/after images differ at that position (see change.checkImmutableColumn).
This is likely not too big of a limitation, as Vitess itself recommends that vindex columns be immutable. If it turns out to be a problem, we can revisit tracking by other columns later.
The sharding column and hash always come from the mapping's SOURCE table — the watched table whose row images we are routing.
func (*MySQLApplier) Wait ¶ added in v0.18.0
func (a *MySQLApplier) Wait(ctx context.Context) error
Wait blocks until all pending work is complete and all callbacks have been invoked. Checking callbacksInFlight in addition to len(pendingWork) is what upholds the "all callbacks have been invoked" half of the contract: claimed work has already left the map, but its callback may still be running (#765).
type Stats ¶ added in v0.16.0
type Stats struct {
// QueueDepth is the number of chunklets currently waiting in the
// buffer(s) — summed across shards for the sharded applier.
QueueDepth int
// QueueCap is the total buffer capacity (summed across shards).
QueueCap int
// PendingWork is the number of chunks accepted by Apply() whose
// callback has not fired yet (queued + in-flight).
PendingWork int
// ActiveWorkers is the number of live write workers.
ActiveWorkers int
// RowsPerChunklet is the mean rows per chunklet since the applier started.
// splitRowsIntoChunklets cuts on whichever of chunkletMaxRows or
// MaxStatementSizeBytes binds first, and which one that is depends on the
// table's width and column types — so it cannot be predicted from the
// config, only measured. It matters because the chunklet is the unit of
// nearly everything on the write path: one statement, one completion, one
// handoff. A value at chunkletMaxRows means the row cap binds and raising
// MaxStatementSizeBytes would do nothing.
//
// A value below the row cap does NOT by itself mean the byte cap binds:
// the mean also drops when the batches handed to Apply() are small — each
// chunk's remainder is a short chunklet, and on the sharded applier a
// chunk is split per shard *after* fan-out, so the same chunk yields more,
// shorter chunklets. The caps-question reading is only sound on the copy
// path's large steady-state batches, where the remainder is noise; there,
// well below the row cap means the byte cap is what's cutting.
//
// A mean rather than a percentile: the question is which cap is in force,
// which the mean answers, and the last chunklet of every chunk is a short
// remainder that would skew a low percentile.
RowsPerChunklet float64
// Rolling percentiles over the last timingRingSize chunklets. Zero when no
// chunklet has completed yet. Together these account for a write worker's
// whole cycle, which matters when the pipeline stops responding to more
// workers: each phase is limited by something different, and only one of
// them is the target's write capacity.
//
// QueueWait is the time a chunklet spent between Apply() offering it to
// the buffer and a write worker dequeueing it (including send-side
// backpressure when the buffer is full).
QueueWaitP50 time.Duration
QueueWaitP90 time.Duration
// BuildTime is the client-side cost of turning the chunklet's rows into an
// INSERT statement — a datum conversion and a string format per value, so
// it scales with rows × columns and is spent on spirit's own CPU while
// holding no connection. It is a *component of* WriteTime, not additional
// to it; subtract it to get time actually spent at the server. A BuildTime
// approaching WriteTime means the client is the bottleneck, which no
// server-side signal (CPU, commit latency, Threads_running) can report and
// which more write workers cannot fix.
BuildTimeP50 time.Duration
BuildTimeP90 time.Duration
// WriteTime is the time spent turning the chunklet into a statement and
// executing it against the target(s) — BuildTime plus the round trip,
// including any retry backoff inside it.
WriteTimeP50 time.Duration
WriteTimeP90 time.Duration
// Handoff is the time a write worker spent publishing its completion after
// the write finished. A single feedbackCoordinator goroutine drains those
// completions and invokes the chunk callback inline, so this is where a
// slow callback shows up as backpressure on every write worker at once.
// Non-trivial Handoff with the queue pegged means workers are blocked
// behind the completion path rather than the target, and adding workers
// will not help.
HandoffP50 time.Duration
HandoffP90 time.Duration
}
Stats is a point-in-time snapshot of an applier's write pipeline. It exists so status blocks and metrics can distinguish a read-limited pipeline (queue near empty) from a write-limited one (queue pegged at capacity with queue-wait far above write time) — without this, write-side saturation is invisible: the copier's end-to-end chunk feedback misattributes it to the read side. All fields are approximate; they are read without pausing the pipeline.
func (Stats) String ¶ added in v0.16.0
String renders the snapshot as the applier row of a runner's status block, so migrate, move and sync report identical fields. Durations are rounded to the millisecond — finer precision is noise at status cadence. The fields are not prefixed with "applier-": the row is labelled, which is the whole point of the block layout.
It renders a deliberately small subset of Stats, because the status block is read every 30 seconds by a human and a field that reads the same on every healthy run costs attention without paying it back (#329). Five fields are always present — queue occupancy, worker count, queue wait, and the write p50/p90 — because those are what you steer by.
Two more appear only when they have something to say: build time when it is a large enough share of write time to mean the client is the bottleneck (and large enough in absolute terms to be worth reading), and handoff when it rises off the floor. Both diagnose a pipeline that has stopped responding to more write workers (see github.com/block/spirit/issues/1097), and both are silent on a healthy run — so their *presence* is the signal, and their absence is not a gap.
Nothing is lost by trimming: every field stays on Stats, and the metrics sink emits them all, which is what dashboards should read anyway.
type Target ¶
type Target struct {
DB *sql.DB
Config *mysql.Config
KeyRange string // Vitess-style key range: "-80", "80-", "80-c0"; "", "0" or "-" for unsharded
}
Target represents a shard target with its database connection, configuration, and key range. Key ranges are expressed as Vitess-style strings (e.g., "-80", "80-", "80-c0"). An empty string, "0" or "-" means all key space (unsharded).